[all-commits] [llvm/llvm-project] 157274: [DebugInfo][Docs] Remove `dbg.addr` from docs

J. Ryan Stinnett via All-commits all-commits at lists.llvm.org
Thu Mar 2 01:31:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1572742cfa10c12f66acb119190ffdf2db6e941c
      https://github.com/llvm/llvm-project/commit/1572742cfa10c12f66acb119190ffdf2db6e941c
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/docs/AssignmentTracking.md
    M llvm/docs/LangRef.rst
    M llvm/docs/ReleaseNotes.rst
    M llvm/docs/SourceLevelDebugging.rst

  Log Message:
  -----------
  [DebugInfo][Docs] Remove `dbg.addr` from docs

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144792


  Commit: c0527fff030799bffd1d7bda01012f8b62363cb2
      https://github.com/llvm/llvm-project/commit/c0527fff030799bffd1d7bda01012f8b62363cb2
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/lib/IR/AutoUpgrade.cpp
    A llvm/test/Bitcode/upgrade-dbg-addr.ll
    A llvm/test/Bitcode/upgrade-dbg-addr.ll.bc
    M llvm/test/Bitcode/upgrade-dbg-value.ll

  Log Message:
  -----------
  [DebugInfo] Upgrade `dbg.addr` to `dbg.value`

As part of removing `dbg.addr`, this upgrades any calls to `dbg.value` with
`DW_OP_deref` prepended onto the value expression.

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144793


  Commit: f5b85c02e94d8556127c91de59174304df37995a
      https://github.com/llvm/llvm-project/commit/f5b85c02e94d8556127c91de59174304df37995a
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

  Log Message:
  -----------
  [DebugInfo][NFC] Remove `FuncArgumentDbgValueKind::Addr` from SelectionDAG

This removes the unused `FuncArgumentDbgValueKind::Addr` value originally added
by e24f5348798605a799c63ff09169d177d262cd37. The intent was to signal the
original intrinsic that marked a function argument, but the `Addr` part was
never used.

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144794


  Commit: 29a6b7dfaec996978e79f378cc57b3ff9074256f
      https://github.com/llvm/llvm-project/commit/29a6b7dfaec996978e79f378cc57b3ff9074256f
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroFrame.cpp
    M llvm/lib/Transforms/Coroutines/CoroSplit.cpp
    R llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
    R llvm/test/Transforms/Coroutines/coro-debug-dbg.addr.ll

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from Coroutines

This removes `dbg.addr` support from the Coroutines transform. This effectively
reverts the `dbg.addr`-only portions of 19279ffc77b8d224c447d4eb0ee0c727ab64babf
and 0b647fc5299156bf83c46aa539d6c9c39647bb36.

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144795


  Commit: ede0fbb19ae4cadb22f0d888e9cffb243c4fdcc4
      https://github.com/llvm/llvm-project/commit/ede0fbb19ae4cadb22f0d888e9cffb243c4fdcc4
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td
    M mlir/test/Dialect/LLVMIR/debuginfo.mlir
    M mlir/test/Target/LLVMIR/Import/debug-info.ll
    M mlir/test/Target/LLVMIR/llvmir-debug.mlir

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from MLIR

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144796


  Commit: 0bbe6040befa0b3debd81526a17cc15361e09f27
      https://github.com/llvm/llvm-project/commit/0bbe6040befa0b3debd81526a17cc15361e09f27
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/Local.h
    M llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
    M llvm/lib/Transforms/Utils/Local.cpp
    M llvm/lib/Transforms/Utils/MemoryOpRemark.cpp
    R llvm/test/Transforms/Mem2Reg/dbg-addr-inline-dse.ll
    R llvm/test/Transforms/Mem2Reg/dbg-addr.ll
    R llvm/test/Transforms/SROA/dbg-addr-diamond.ll
    M llvm/test/Transforms/SpeculativeExecution/PR46267.ll
    M llvm/test/Transforms/Util/strip-nonlinetable-debuginfo-localvars.ll
    M llvm/unittests/Transforms/Utils/LocalTest.cpp

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from Transforms

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144797


  Commit: 065e77b1b7f30510f3dd93298e8a33ecfbc6bd65
      https://github.com/llvm/llvm-project/commit/065e77b1b7f30510f3dd93298e8a33ecfbc6bd65
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/test/tools/llvm-reduce/remove-args-dbg-intrinsics.ll

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from llvm-reduce

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144798


  Commit: 8ed6c9220e139bf0bdc41d181bdb7e8463ea0820
      https://github.com/llvm/llvm-project/commit/8ed6c9220e139bf0bdc41d181bdb7e8463ea0820
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/lib/Analysis/MemorySSA.cpp

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from Analysis

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144799


  Commit: 22b8e82c12e186413538c91b7dbc257b42a73f04
      https://github.com/llvm/llvm-project/commit/22b8e82c12e186413538c91b7dbc257b42a73f04
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
    M llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    R llvm/test/DebugInfo/X86/dbg-addr-dse.ll
    R llvm/test/DebugInfo/X86/dbg-addr.ll
    M llvm/test/DebugInfo/X86/merge-equivalent-ranges.ll

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from CodeGen

As part of this work, removing `SDDbgValue::clearIsEmitted` originally added for
`dbg.addr` in 045c67769d7fe577fc38cccb6fb40fd814437447 was attempted, but it
appears some tests for `DBG_INSTR_REF` now depend on that behaviour as well, so
it was kept and comments were updated instead.

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144800


  Commit: 1f9d42aedacdd65141a043421526a51f8944b552
      https://github.com/llvm/llvm-project/commit/1f9d42aedacdd65141a043421526a51f8944b552
  Author: J. Ryan Stinnett <jryans at gmail.com>
  Date:   2023-03-02 (Thu, 02 Mar 2023)

  Changed paths:
    M llvm/include/llvm/IR/DIBuilder.h
    M llvm/include/llvm/IR/DebugInfo.h
    M llvm/include/llvm/IR/DebugInfoMetadata.h
    M llvm/include/llvm/IR/IntrinsicInst.h
    M llvm/include/llvm/IR/Intrinsics.td
    M llvm/lib/IR/DIBuilder.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/unittests/IR/BasicBlockTest.cpp
    M llvm/unittests/IR/DebugInfoTest.cpp

  Log Message:
  -----------
  [DebugInfo] Remove `dbg.addr` from IR

Part of `dbg.addr` removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Differential Revision: https://reviews.llvm.org/D144801


Compare: https://github.com/llvm/llvm-project/compare/b30422eac5aa...1f9d42aedacd


More information about the All-commits mailing list