[all-commits] [llvm/llvm-project] f5f8a4: [mlir][AsmParser] Improve parse{Attribute, Type} er...

[rk via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5f8a46bb0ce3dd2f3e024696d5a0aef5fb12a29
      https://github.com/llvm/llvm-project/commit/f5f8a46bb0ce3dd2f3e024696d5a0aef5fb12a29
  Author: Rahul Kayaith <rkayaith at gmail.com>
  Date:   2023-03-01 (Wed, 01 Mar 2023)

  Changed paths:
    M mlir/include/mlir/AsmParser/AsmParser.h
    M mlir/lib/AsmParser/DialectSymbolParser.cpp
    M mlir/lib/Bytecode/Reader/BytecodeReader.cpp
    M mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
    M mlir/test/Dialect/Linalg/transform-op-pad.mlir
    M mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp
    M mlir/unittests/Parser/ParserTest.cpp

  Log Message:
  -----------
  [mlir][AsmParser] Improve parse{Attribute,Type} error handling

Currently these functions report errors directly to stderr, this updates
them to use diagnostics instead. This also makes partially-consumed
strings an error if the `numRead` parameter isn't provided (the
docstrings already claimed this happened, but it didn't.)

While here I also tried to reduce the number of overloads by switching
to using default parameters.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D144804