[all-commits] [llvm/llvm-project] e8a2fd: An SBValue whose underlying ValueObject has no val...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8a2fd5e7be23e4087e7ff58efa354dfae1a17c4
      https://github.com/llvm/llvm-project/commit/e8a2fd5e7be23e4087e7ff58efa354dfae1a17c4
  Author: Jim Ingham <jingham at apple.com>
  Date:   2023-02-28 (Tue, 28 Feb 2023)

  Changed paths:
    M lldb/source/API/SBValue.cpp
    M lldb/source/Core/ValueObject.cpp
    M lldb/source/DataFormatters/ValueObjectPrinter.cpp

  Log Message:
  -----------
  An SBValue whose underlying ValueObject has no valid value, but does
hold an error should:

(a) return false for IsValid, since that's the current behavior and is
    a convenient way to check "should I get the value for this".
(b) preserve the error when an SBValue is made from it, and print the
    error in the ValueObjectPrinter.

Make that happen.

Differential Revision: https://reviews.llvm.org/D144664