[all-commits] [llvm/llvm-project] 7d7633: [Flang][OpenMP][OpenACC] Error for loop with no co...

[kiranchandramohan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d7633bdf489eff66a56984a4cf3d6a21cf36f2b
      https://github.com/llvm/llvm-project/commit/7d7633bdf489eff66a56984a4cf3d6a21cf36f2b
  Author: Kiran Chandramohan <kiran.chandramohan at arm.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M flang/lib/Semantics/resolve-directives.cpp
    M flang/test/Semantics/OpenACC/acc-loop.f90
    M flang/test/Semantics/OpenMP/do-collapse.f90
    A flang/test/Semantics/OpenMP/omp-do-collapse1.f90

  Log Message:
  -----------
  [Flang][OpenMP][OpenACC] Error for loop with no control

Issue error if a DO construct associated with a loop does not have
loop control. Currently, it is issued only for the loop immediately
following the loop construct. This patch extends it to cases like
collapse where there is more than one loop associated. It also fixes
a crash since the existing code always expects loop control.

This is covered in OpenMP 4.5 standard, Section 2.7.1.
"The do-loop cannot be a DO WHILE or a DO loop without loop control."

OpenACC 3.3 covers this indirectly in Section 2.9.1.
The trip count for all loops associated with the collapse clause must
be computable and invariant in all the loops".

Reviewed By: clementval

Differential Revision: https://reviews.llvm.org/D144290