[all-commits] [llvm/llvm-project] ba63dd: [X86] Move atomics test for !pcsections into separ...

[Marco Elver via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba63ddd595de588b3540a5e49516e22a9d23cb24
      https://github.com/llvm/llvm-project/commit/ba63ddd595de588b3540a5e49516e22a9d23cb24
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    A llvm/test/CodeGen/X86/pcsections-atomics.ll
    M llvm/test/CodeGen/X86/pcsections.ll

  Log Message:
  -----------
  [X86] Move atomics test for !pcsections into separate file

The pcsections.ll test primarily tests that the AsmPrinter produces the
right output in sections. This output is not easily covered by
update_llc_test_checks.py, and as such is hand written. This makes
maintenance rather burdensome. Instead, let's keep pcsections.ll as
simple as possible.

Move the more complex tests that primarily test that some atomic
operations end up in the PC section to pcsections-atomics.ll.

NFC.

Reviewed By: dvyukov, vitalybuka

Differential Revision: https://reviews.llvm.org/D144675


  Commit: a5653b82d0b419b4a4c6ec10210e713de4a158a6
      https://github.com/llvm/llvm-project/commit/a5653b82d0b419b4a4c6ec10210e713de4a158a6
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M llvm/test/CodeGen/X86/pcsections-atomics.ll

  Log Message:
  -----------
  [X86] Improve atomics test for !pcsections

Extend pcsections-atomics.ll to exhaustively test all atomic ops up to
64 bits. This currently shows that some atomic operations do not end up
in PC sections. This will be addressed in a subsequent change.

Differential Revision: https://reviews.llvm.org/D144710


  Commit: d73da86812137312e559e2b01a88f16f1896968e
      https://github.com/llvm/llvm-project/commit/d73da86812137312e559e2b01a88f16f1896968e
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M llvm/lib/Target/X86/X86FixupBWInsts.cpp
    M llvm/test/CodeGen/X86/pcsections-atomics.ll

  Log Message:
  -----------
  [X86][FixupBWInsts] Fix propagation of !pcsections metadata

Use MIMetadata() to propagate both DebugLoc and !pcsections metadata.

This fixes several of the non-native sized !pcsections tests in
pcsections-atomics.ll.

Reviewed By: dvyukov

Differential Revision: https://reviews.llvm.org/D144676


  Commit: 7f635b90e7bdf1378fd9a65fc62b99e8e07d4aaf
      https://github.com/llvm/llvm-project/commit/7f635b90e7bdf1378fd9a65fc62b99e8e07d4aaf
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
    M llvm/test/CodeGen/X86/pcsections-atomics.ll

  Log Message:
  -----------
  [SelectionDAG] Transitively copy NodeExtraInfo on RAUW

During legalization of the SelectionDAG, some nodes are replaced with
arch-specific nodes. These may be complex nodes, where the root node no
longer corresponds to the node that should carry the extra info.

Fix the issue by copying extra info to the new node and all its new
transitive operands during RAUW. See code comments for more details.

This fixes the remaining pcsections-atomics.ll tests on X86.

Reviewed By: dvyukov

Differential Revision: https://reviews.llvm.org/D144677


Compare: https://github.com/llvm/llvm-project/compare/47f9109dff80...7f635b90e7bd