[all-commits] [llvm/llvm-project] cb2d04: [clangd] Hide inlay hints when using a macro as a ...

zyn0217 via All-commits all-commits at lists.llvm.org
Sun Feb 26 03:06:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb2d04d41e47e65812434f775215247bfe19b3dd
      https://github.com/llvm/llvm-project/commit/cb2d04d41e47e65812434f775215247bfe19b3dd
  Author: Younan Zhang <zyn7109 at gmail.com>
  Date:   2023-02-26 (Sun, 26 Feb 2023)

  Changed paths:
    M clang-tools-extra/clangd/InlayHints.cpp
    M clang-tools-extra/clangd/unittests/InlayHintTests.cpp

  Log Message:
  -----------
  [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

We don't want to produce inlay hints for arguments for which
user has left param name comments. But we're not decomposing
location of the parameter correctly at the moment because the
location we've passed into `SM.getDecomposedLoc` is not always
FileID.

Fixes clangd/clangd#1495

Reviewed By: nridge

Differential Revision: https://reviews.llvm.org/D144074




More information about the All-commits mailing list