[all-commits] [llvm/llvm-project] 724b58: [PDB] Error on too large stream directories

Hans via All-commits all-commits at lists.llvm.org
Fri Feb 24 06:12:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 724b58f76691e5633fc9e2e19d64e476b0c7845e
      https://github.com/llvm/llvm-project/commit/724b58f76691e5633fc9e2e19d64e476b0c7845e
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2023-02-24 (Fri, 24 Feb 2023)

  Changed paths:
    M lld/COFF/PDB.cpp
    M llvm/include/llvm/DebugInfo/MSF/MSFError.h
    M llvm/lib/DebugInfo/MSF/MSFBuilder.cpp
    M llvm/lib/DebugInfo/MSF/MSFError.cpp

  Log Message:
  -----------
  [PDB] Error on too large stream directories

We hit this in Chromium builds where the PDB file was just under 4GB,
but the stream directory was actually too large to be correctly
represented.

llvm-pdbutil would error about this in llvm::msf::validateSuperBlock,
but lld should not write such PDB files in the first place.

Differential revision: https://reviews.llvm.org/D144385




More information about the All-commits mailing list