[all-commits] [llvm/llvm-project] dbf149: [RISCV] Properly diagnose mixing RVV scalable vect...

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Feb 23 09:00:49 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
    M clang/include/clang/AST/Type.h
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/Type.cpp
    M clang/lib/Sema/SemaExpr.cpp
    A clang/test/Sema/attr-riscv-rvv-vector-bits.c

  Log Message:
  [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

This case was being picked up by SVE code and printing an SVE
specific message.

This patch distinquishes RVV from SVE and provides a correct error
message for RVV.

The use of the generic isSizelessBuiltinType was also picking up
WebAssembly reference types which was probably an accident so I've
removed that.

I've named the test similar to SVE's test that contains this check.
Their test also tests the arm_sve_vector_bits attribute. I plan to
add something similar for RISC-V soon so I've adopted this naming.

Reviewed By: c-rhodes

Differential Revision: https://reviews.llvm.org/D144613

More information about the All-commits mailing list