[all-commits] [llvm/llvm-project] 6c2a78: [InstCombine] add test for splat-of-binop; NFC

Sanjay Patel via All-commits all-commits at lists.llvm.org
Wed Feb 22 16:24:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c2a7817f8206d06101e4aa6950a113da395de38
      https://github.com/llvm/llvm-project/commit/6c2a7817f8206d06101e4aa6950a113da395de38
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M llvm/test/Transforms/InstCombine/shuffle-binop.ll

  Log Message:
  -----------
  [InstCombine] add test for splat-of-binop; NFC

This shows a missing extra use check.


  Commit: 40d772c642f70736d935bff0420a9bd1c1f80ab6
      https://github.com/llvm/llvm-project/commit/40d772c642f70736d935bff0420a9bd1c1f80ab6
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
    M llvm/test/Transforms/InstCombine/shuffle-binop.ll

  Log Message:
  -----------
  [InstCombine] add one-use check to prevent creating an instruction in shuffle-of-binop

This fold was added with https://reviews.llvm.org/D135876 ,
but we missed the one-use check.

This might be the root cause for issue #60632.


Compare: https://github.com/llvm/llvm-project/compare/225f11cff7fb...40d772c642f7


More information about the All-commits mailing list