[all-commits] [llvm/llvm-project] 80a8e6: [AMDGPU] Don't set src mods on permlane16
Joe Nash via All-commits
all-commits at lists.llvm.org
Wed Feb 22 08:42:18 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 80a8e6805ab8e318662240d63e1e3b6c08667b45
https://github.com/llvm/llvm-project/commit/80a8e6805ab8e318662240d63e1e3b6c08667b45
Author: Joe Nash <Joseph.Nash at amd.com>
Date: 2023-02-22 (Wed, 22 Feb 2023)
Changed paths:
M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
M llvm/lib/Target/AMDGPU/VOP3Instructions.td
M llvm/test/CodeGen/AMDGPU/permlane-op-sel.ll
A llvm/test/CodeGen/AMDGPU/permlane16_opsel.ll
Log Message:
-----------
[AMDGPU] Don't set src mods on permlane16
v_permlane16_b32 and v_permlanex16_b32 should not set abs and neg src
modifiers on any input, but they can set op_sel on src0 or src1 to
represent fi or bc when desired. The ISel patterns were setting
the src_modifier bits to -1, effectively setting abs and neg as well,
whenever it was intended to set op_sel, due to an error in ISel. ISel
should now correctly only set the op_sel bits.
Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D144519
More information about the All-commits
mailing list