[all-commits] [llvm/llvm-project] efae31: [CMake] Unify llvm_check_linker_flag and llvm_chec...

Petr Hosek via All-commits all-commits at lists.llvm.org
Tue Feb 21 20:25:18 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: efae3174f09560353fb0f3d528bcbffe060d5438
  Author: Petr Hosek <phosek at google.com>
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
    R cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake
    A cmake/Modules/LLVMCheckLinkerFlag.cmake
    M compiler-rt/cmake/config-ix.cmake
    M libcxx/cmake/config-ix.cmake
    M libunwind/cmake/config-ix.cmake
    R llvm/cmake/modules/LLVMCheckLinkerFlag.cmake
    M runtimes/CMakeLists.txt

  Log Message:
  [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

These have the same purposes but two different implementations.
llvm_check_compiler_linker_flag uses CMAKE_REQUIRED_FLAGS which affects
flags used both for compilation and linking which is problematic because
some flags may be link-only and trigger unused argument warning when set
during compilation. llvm_check_linker_flag does not have this issue so
we chose it as the prevailaing implementation.

Differential Revision: https://reviews.llvm.org/D143052

More information about the All-commits mailing list