[all-commits] [llvm/llvm-project] 87d02e: Recommit "[Support] change StringMap hash function...

[erikdesjardins via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 87d02e0dfd760de38d092ef69f8a9164f28f2221
      https://github.com/llvm/llvm-project/commit/87d02e0dfd760de38d092ef69f8a9164f28f2221
  Author: Erik Desjardins <erikdesjardinspublic at gmail.com>
  Date:   2023-02-19 (Sun, 19 Feb 2023)

  Changed paths:
    M clang-tools-extra/test/modularize/ProblemsDisplayLists.modularize
    M clang/unittests/Basic/SarifTest.cpp
    M compiler-rt/test/profile/Linux/instrprof-show-debug-info-correlation.c
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M llvm/lib/Support/StringMap.cpp
    M llvm/test/DebugInfo/Generic/accel-table-hash-collisions.ll
    M llvm/test/DebugInfo/Generic/debug-names-hash-collisions.ll
    M llvm/test/DebugInfo/X86/debug-pubtables-dwarf64.ll
    M llvm/test/DebugInfo/X86/gnu-public-names-gmlt.ll
    M llvm/test/DebugInfo/X86/gnu-public-names.ll
    M llvm/test/tools/dsymutil/ARM/extern-alias.test
    M llvm/test/tools/llvm-profdata/suppl-instr-with-sample.test
    M mlir/test/mlir-lsp-server/completion.test

  Log Message:
  -----------
  Recommit "[Support] change StringMap hash function from djbHash to xxHash"

This reverts commit 37eb9d13f891f7656f811516e765b929b169afe0.

Test failures have been fixed:

- ubsan failure fixed by 72eac42f21c0f45a27f3eaaff9364cbb5189b9e4
- warn-unsafe-buffer-usage-fixits-local-var-span.cpp fixed by
  03cc52dfd1dbb4a59b479da55e87838fb93d2067 (wasn't related)
- test-output-format.ll failure was spurious, build failed at
  https://lab.llvm.org/buildbot/#/builders/54/builds/3545 (b4431b2d945b6fc19b1a55ac6ce969a8e06e1e93)
  but passed at
  https://lab.llvm.org/buildbot/#/builders/54/builds/3546 (5ae99be0377248c74346096dc475af254a3fc799)
  which is before my revert
  https://github.com/llvm/llvm-project/compare/b4431b2d945b6fc19b1a55ac6ce969a8e06e1e93...5ae99be0377248c74346096dc475af254a3fc799

Original commit message:

    Depends on https://reviews.llvm.org/D142861.

    Alternative to https://reviews.llvm.org/D137601.

    xxHash is much faster than djbHash. This makes a simple Rust test case with a large constant string 10% faster to compile.

    Previous attempts at changing this hash function (e.g. https://reviews.llvm.org/D97396) had to be reverted due to breaking tests that depended on iteration order.
    No additional tests fail with this patch compared to `main` when running `check-all` with `-DLLVM_ENABLE_PROJECTS="all"` (on a Linux host), so I hope I found everything that needs to be changed.

    Differential Revision: https://reviews.llvm.org/D142862