[all-commits] [llvm/llvm-project] 2f88c0: [lldb] StructuredData should not truncate uint64_t...

Alex via All-commits all-commits at lists.llvm.org
Fri Feb 17 12:40:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f88c07cf820cff829dec5906d298fc7147af8dd
      https://github.com/llvm/llvm-project/commit/2f88c07cf820cff829dec5906d298fc7147af8dd
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-02-17 (Fri, 17 Feb 2023)

  Changed paths:
    M lldb/source/Utility/StructuredData.cpp
    M lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py

  Log Message:
  -----------
  [lldb] StructuredData should not truncate uint64_t values

In json::Value, getAsInteger returns an optional<int64_t> and getAsNumber
returns an optional<double>. If a value is larger than what an int64_t
can hold but smaller than what a uint64_t can hold, the getAsInteger
function will fail but the getAsNumber will succeed. However, the value
shouldn't be interpreted as a double.

rdar://105556974

Differential Revision: https://reviews.llvm.org/D144238




More information about the All-commits mailing list