[all-commits] [llvm/llvm-project] eb1418: Revert "[LLD] [COFF] Don't try to detect MSVC inst...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eb14186771e7bca992c043637aac3ed7104eaa1f
      https://github.com/llvm/llvm-project/commit/eb14186771e7bca992c043637aac3ed7104eaa1f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-02-17 (Fri, 17 Feb 2023)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/test/COFF/winsysroot.test

  Log Message:
  -----------
  Revert "[LLD] [COFF] Don't try to detect MSVC installations in mingw mode"

This reverts commit 389bfbd66d6f78b5fc60e51e620e7f767fc867f0.

This commit broke the compiler-rt/test/profile/Windows/coverage-weak-lld.cpp
testcase. This testcase builds and links in an MSVC environment,
but explicitly passes -lldmingw to the linker, to opt in to
certain mingw-style behaviours regarding weak symbols, since
effb87dfa810a28e763f914fe3e6e984782cc846. This patch broke that
test, which now errored out with these errors:

    lld-link: error: could not open 'libuuid.a': no such file or directory
    lld-link: error: could not open 'libLIBCMT.a': no such file or directory
    lld-link: error: could not open 'libOLDNAMES.a': no such file or directory