[all-commits] [llvm/llvm-project] 48c8e1: Revert "[Libomptarget] Check errors when synchroni...

Joseph Huber via All-commits all-commits at lists.llvm.org
Thu Feb 16 12:56:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 48c8e16020483b9a2699b7bacda99e8fd0a6d051
      https://github.com/llvm/llvm-project/commit/48c8e16020483b9a2699b7bacda99e8fd0a6d051
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M openmp/libomptarget/include/omptarget.h
    M openmp/libomptarget/src/interface.cpp
    M openmp/libomptarget/src/omptarget.cpp
    M openmp/libomptarget/src/private.h

  Log Message:
  -----------
  Revert "[Libomptarget] Check errors when synchronizing the async queue"

This reverts commit 861709107b43d40ad366e0efd225cb804be3b44d.

Reverting this to reland as it will make it easier to backport.


  Commit: 5172877bbddc4e718e4bee57369c820d82f9a784
      https://github.com/llvm/llvm-project/commit/5172877bbddc4e718e4bee57369c820d82f9a784
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M openmp/libomptarget/include/omptarget.h
    M openmp/libomptarget/src/interface.cpp
    M openmp/libomptarget/src/omptarget.cpp
    M openmp/libomptarget/src/private.h

  Log Message:
  -----------
  [Libomptarget] Check errors when synchronizing the async queue

Summary:
Currently when we synchronize the asynchronous queue for the plugins, we
ignore the return value. This is problematic because we will continue on
like nothing happened if the kernel fails.

Fixes https://github.com/llvm/llvm-project/issues/60814

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D144191


Compare: https://github.com/llvm/llvm-project/compare/53862b5658dd...5172877bbddc


More information about the All-commits mailing list