[all-commits] [llvm/llvm-project] 26662a: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* ...

Jeremy Maitin-Shepard via All-commits all-commits at lists.llvm.org
Tue Feb 14 16:21:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26662ac010ef50e65e2774eab84f325aa09360fe
      https://github.com/llvm/llvm-project/commit/26662ac010ef50e65e2774eab84f325aa09360fe
  Author: Jeremy Maitin-Shepard <jbms at google.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_unix.S
    M llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
    M llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_msvc.asm
    M llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_unix.S
    M llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
    M llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_msvc.asm
    M llvm/lib/Support/BLAKE3/blake3_impl.h
    M llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_unix.S
    M llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
    M llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_msvc.asm
    M llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_unix.S
    M llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
    M llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_msvc.asm
    A llvm/lib/Support/BLAKE3/llvm_blake3_prefix.h

  Log Message:
  -----------
  [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions

While some blake3 symbols are already prefixed, a number of symbols with hidden visibility have been left without an `llvm_` prefix.  This results in symbol collisions when statically linking llvm into a binary that also uses the external blake3 library.

Reviewed By: akyrtzi, MaskRay

Differential Revision: https://reviews.llvm.org/D143981




More information about the All-commits mailing list