[all-commits] [llvm/llvm-project] 7fdc2e: [mlir] reallow null results in TransformEachOpTrait

ftynse via All-commits all-commits at lists.llvm.org
Tue Feb 14 02:11:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7fdc2ed09f441e7e0ca5c88d947e99f259291963
      https://github.com/llvm/llvm-project/commit/7fdc2ed09f441e7e0ca5c88d947e99f259291963
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
    M mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
    M mlir/test/Dialect/Transform/test-interpreter.mlir
    M mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.td

  Log Message:
  -----------
  [mlir] reallow null results in TransformEachOpTrait

Previous changes in 98acd7468307b6099e7deae206a749af324ff95f were overly
eager to disallow null payload everywhere. The semantics of
TransformEachOpTrait allows individual applications to return null
payloads as means of filtering out the operations to which they are not
applicable without emitting even a silenceable failure. This is a
questionable choice, but one apparently relied upon. Null payloads are
not supposed to leak outside of the trait.

Reviewed By: qcolombet

Differential Revision: https://reviews.llvm.org/D143904




More information about the All-commits mailing list