[all-commits] [llvm/llvm-project] ee88f1: Find SDK path more lazily in Apple Simulator platf...

Jason Molenda via All-commits all-commits at lists.llvm.org
Mon Feb 13 15:17:10 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee88f11770032eac8998664e7102d37f54b9f027
  Author: Jason Molenda <jason at molenda.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h

  Log Message:
  Find SDK path more lazily in Apple Simulator platforms

In https://reviews.llvm.org/D122373 I delayed the search for
the SDK filepath until the simulator platform is Created.
In the qProcessInfo binary-addresses key, I have to force-Create
every platform to find one that can handle a kernel fileset;
this forced all of the simulator platforms to create, taking the
SDK filepath discovery perf hit.

This patch delays that path search further until the Apple
Simulator platform calls a method that actually needs the full
filepath; it saves the SDK name ("WatchSimulator.sdk" etc) until
it needs to expand it.

Differential Revision: https://reviews.llvm.org/D143932

More information about the All-commits mailing list