[all-commits] [llvm/llvm-project] 8a5774: Revert "[lldb][Test][NFC] TestExternalCtorDtorLook...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a57748804bd2247a8c0c5632af3364db58a087f
      https://github.com/llvm/llvm-project/commit/8a57748804bd2247a8c0c5632af3364db58a087f
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
    R lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.cpp
    M lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
    M lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp

  Log Message:
  -----------
  Revert "[lldb][Test][NFC] TestExternalCtorDtorLookup: add more instantiations to test linkage name is correct"

This reverts commit 3c160d3051dc5d637bd35cfa673871338589ad8e.

This patch depends on the reverted patch in https://reviews.llvm.org/D143652

Differential Revision: https://reviews.llvm.org/D143652


  Commit: bf7c421617007d7202dcd74762cef3a49425bfab
      https://github.com/llvm/llvm-project/commit/bf7c421617007d7202dcd74762cef3a49425bfab
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    R lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
    R lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py
    R lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
    R lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp

  Log Message:
  -----------
  Revert "Reland "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing""

This reverts commit 19128792e2aa320c1a149f7f93638cbd7f3c83c6.

As pointed out in https://reviews.llvm.org/D143652 this implementation
doesn't quite work for subobject constructors/destructors because DWARF
can map multiple definitions of a ctor/dtor to the same specification DIE.
With the current implementation we would pick the first definition we
find and use that linkage name which means we can sometimes pick the
wrong dtor/ctor and fail to execute a valid expression.

Differential Revision: https://reviews.llvm.org/D143652


Compare: https://github.com/llvm/llvm-project/compare/9dd1168fe115...bf7c42161700