[all-commits] [llvm/llvm-project] 9e3010: [AArch64] Fix LSE2/LSE128/RCPC3 precedence

tmatheson-arm via All-commits all-commits at lists.llvm.org
Mon Feb 13 04:32:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e3010ad992d7e6ae04ab1c2a608513c4de30b83
      https://github.com/llvm/llvm-project/commit/9e3010ad992d7e6ae04ab1c2a608513c4de30b83
  Author: Tomas Matheson <tomas.matheson at arm.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    M llvm/lib/Target/AArch64/AArch64ISelLowering.h
    R llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-load-lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-store-lse128.ll
    M llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-store-lse2_lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64-cmpxchg-lse128.ll
    M llvm/test/CodeGen/AArch64/Atomics/aarch64-fence.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-load-lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-store-lse128.ll
    M llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-store-lse2_lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomicrmw-lse128.ll
    R llvm/test/CodeGen/AArch64/Atomics/aarch64_be-cmpxchg-lse128.ll
    M llvm/test/CodeGen/AArch64/Atomics/aarch64_be-fence.ll
    M llvm/test/CodeGen/AArch64/Atomics/generate-tests.py

  Log Message:
  -----------
  [AArch64] Fix LSE2/LSE128/RCPC3 precedence

D142712 added tests for when both lse2 and lse128 are available, but
in practice there is no way to enable LSE128 without LSE2 from clang:
LSE128 is a v9 only feature and LSE2 has been mandatory since v8.4,
and +/-lse2 can not be specified on the clang command line.

Therefore it makes more sense that lse2+lse128 should emit lse128
instructions, otherwise they will not be emitted at all.

It also makes sense to remove the lse128-only backend tests if that set
of attributes is never set by the frontend.

Differential Revision: https://reviews.llvm.org/D143506




More information about the All-commits mailing list