[all-commits] [llvm/llvm-project] fdd18e: [llvm][TableGen][Jupyter] Show llvm-tblgen not fou...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fdd18e866b050ed89e59c214bf559d81ed90d57f
      https://github.com/llvm/llvm-project/commit/fdd18e866b050ed89e59c214bf559d81ed90d57f
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M llvm/utils/TableGen/jupyter/tablegen_kernel/kernel.py

  Log Message:
  -----------
  [llvm][TableGen][Jupyter] Show llvm-tblgen not found error in notebook

Previously this message was only shown on the command line,
which is not much help if you can't see that.
(you've full screened the browser or you aren't running Jupyter
on the same machine)

Instead return the error as stderr which will get printed in
the notebook just like stderr from llvm-tblgen would.

I've refactored the message sending along the way. Note that
even when we do not send a stream, we still need to send the
status reply. The send_... methods will do that for you.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D142531