[all-commits] [llvm/llvm-project] fae01d: [clangd] Fix bugs in main-file include patching fo...

kadir ├žetinkaya via All-commits all-commits at lists.llvm.org
Mon Feb 13 00:49:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fae01d175a29270ec01211d3988c7ae57ddabfd3
      https://github.com/llvm/llvm-project/commit/fae01d175a29270ec01211d3988c7ae57ddabfd3
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M clang-tools-extra/clangd/Preamble.cpp
    M clang-tools-extra/clangd/unittests/PreambleTests.cpp

  Log Message:
  -----------
  [clangd] Fix bugs in main-file include patching for stale preambles

- Make sure main file includes are present even when they're not patched
  (because they didn't change or we're explicitly not patching them).
- Populate extra fields for includes, which can be used by include-cleaner.

Differential Revision: https://reviews.llvm.org/D143197


  Commit: 19659b5f0dd1a1dcf745cf058d042ada2d4ff061
      https://github.com/llvm/llvm-project/commit/19659b5f0dd1a1dcf745cf058d042ada2d4ff061
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M clang-tools-extra/clangd/Preamble.cpp
    M clang-tools-extra/clangd/unittests/PreambleTests.cpp

  Log Message:
  -----------
  [clangd] Drop includes from disabled PP regions in preamble patch

In rest of the clangd functionality we treat these includes as
non-existent. Do so under preamble patching.

Depends on D143197

Differential Revision: https://reviews.llvm.org/D143597


Compare: https://github.com/llvm/llvm-project/compare/f79a5fb9df42...19659b5f0dd1


More information about the All-commits mailing list