[all-commits] [llvm/llvm-project] 191287: Reland "[lldb][DWARFASTParserClang] Attach linkage...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19128792e2aa320c1a149f7f93638cbd7f3c83c6
      https://github.com/llvm/llvm-project/commit/19128792e2aa320c1a149f7f93638cbd7f3c83c6
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2023-02-12 (Sun, 12 Feb 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    A lldb/test/API/lang/cpp/external_ctor_dtor_lookup/Makefile
    A lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py
    A lldb/test/API/lang/cpp/external_ctor_dtor_lookup/lib.h
    A lldb/test/API/lang/cpp/external_ctor_dtor_lookup/main.cpp

  Log Message:
  -----------
  Reland "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing"

This relands the commit previously reverted in
`d2cc2c5610ffa78736aa99512bc85a85417efb0a` due to failures on Linux
when debugging split-debug-info enabled executables.

The problem was we called `SymbolFileDWARF::FindFunctions` directly
instead of `Module::FindFunctions` which resulted in a nullptr
dereference because the backing `SymbolFileDWARFDwo` didn't have
an index attached to it. The relanded version calls `Module::FindFunctions`
instead.

Differential Revision: https://reviews.llvm.org/D143652