[all-commits] [llvm/llvm-project] e8a79d: [flang] Do not print backtrace for most TODOs.

Slava Zakharin via All-commits all-commits at lists.llvm.org
Fri Feb 10 15:08:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e8a79dc3d8ebcd5474dab35f180fc0dee77236ab
      https://github.com/llvm/llvm-project/commit/e8a79dc3d8ebcd5474dab35f180fc0dee77236ab
  Author: Slava Zakharin <szakharin at nvidia.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M flang/include/flang/Optimizer/Builder/Todo.h
    M flang/include/flang/Optimizer/Support/FatalError.h
    M flang/test/lit.cfg.py

  Log Message:
  -----------
  [flang] Do not print backtrace for most TODOs.

There are two ways to interrupt flang when a TODO is hit: abort or
exit with non-zero exit code. Abort implies printing the backtrace
and "PLEASE submit a bug report" message. We used to use abort
only in debug compiler build. Since the TODOs are already known
problems it may be counterproductive to ask debug compiler users
to submit bug reports. In addition, the TODO messages are pretty
self-explanatory, so the backtrace printing seems to be redundant.

This change makes all TODOs non-aborting. I added TODO_.*TRACE macros
for TODOs that may benefit from the backtrace and the "bug report"
message in the debug compiler. These macros are currently unused.

Differential Revision: https://reviews.llvm.org/D143761




More information about the All-commits mailing list