[all-commits] [llvm/llvm-project] bb059e: [Assignment Tracking][SROA] Delete dbg.assigns lin...

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb059e85d61b48cff4334b33f63eb5680c3c8d50
      https://github.com/llvm/llvm-project/commit/bb059e85d61b48cff4334b33f63eb5680c3c8d50
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/test/DebugInfo/Generic/assignment-tracking/sroa/complex.ll

  Log Message:
  -----------
  [Assignment Tracking][SROA] Delete dbg.assigns linked to rewritten stores

AggLoadStoreRewriter splits aggregate loads and stores into scalars (before the
alloca is split up). The new stores and debug intrinsics are already wired up
correctly - we just need to also delete the dbg.assign that is linked to the
split to-be-deleted store too.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D142882


  Commit: 4ad8f7a189570dc2560d0efdd05e6a8153313808
      https://github.com/llvm/llvm-project/commit/4ad8f7a189570dc2560d0efdd05e6a8153313808
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

  Log Message:
  -----------
  [Assignment Tracking][mem2reg] Remove overly defensive assert

The assert fires if a store to an alloca with no linked dbg.assigns has linked
dbg.assigns. This can happen in the wild due to optimisations dropping the
alloca's debug info so we shouldn't assert against it.

Reviewed By: jryans

Differential Revision: https://reviews.llvm.org/D143153


Compare: https://github.com/llvm/llvm-project/compare/65f9719913ec...4ad8f7a18957