[all-commits] [llvm/llvm-project] fc2c79: [mlir][llvm] Fix TBAA verfication crash

Christian Ulmann via All-commits all-commits at lists.llvm.org
Thu Feb 9 23:39:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc2c791e89cd10ab9225421f215c2267e832977f
      https://github.com/llvm/llvm-project/commit/fc2c791e89cd10ab9225421f215c2267e832977f
  Author: Christian Ulmann <christian.ulmann at nextsilicon.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

  Log Message:
  -----------
  [mlir][llvm] Fix TBAA verfication crash

This commit fixes a crash of the TBAA verification that happened due to
accessing memory through invalid pointers. A DenseMap does not guarantee
that pointers to its elements remain valid after additional elements
are inserted.

A testcase that caused this crash had more than 100 TBAA metadata
operations and thus no test is added. Instead, there is now an assertion
that ensures that the graph class is used correctly.

Reviewed By: vzakhari

Differential Revision: https://reviews.llvm.org/D143653




More information about the All-commits mailing list