[all-commits] [llvm/llvm-project] 21fc8d: [compiler-rt][macOS]: Disable iOS support if iOS S...

Thu Feb 9 05:01:02 PST 2023

  Branch: refs/heads/release/16.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 21fc8d0bc2b19021ac0f7a83da01cca25045eea0
      https://github.com/llvm/llvm-project/commit/21fc8d0bc2b19021ac0f7a83da01cca25045eea0
  Author: Tobias Hieta <tobias at plex.tv>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M compiler-rt/cmake/base-config-ix.cmake

  Log Message:
  -----------
  [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found

If you are missing the iOS SDK on your macOS (for example you don't have
full Xcode but just CommandLineTools) then CMake currently errors
out without a helpful message. This patch disables iOS support in
compiler-rt if the iOS SDK is not found. This can be overriden by
passing -DCOMPILER_RT_ENABLE_IOS=ON.

Reviewed By: delcypher, thetruestblue

Differential Revision: https://reviews.llvm.org/D133273

(cherry picked from commit 78fb02107ae5819501af2600b0bebd48c1900a9b)

  Commit: af5fa490954098e3d2d0e32075da476d1c82b148
      https://github.com/llvm/llvm-project/commit/af5fa490954098e3d2d0e32075da476d1c82b148
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    A llvm/test/CodeGen/ARM/inlineasmbr-if-cvt.mir

  Log Message:
  -----------
  precommit test for pr60346

Link: https://github.com/llvm/llvm-project/issues/60346

Reviewed By: efriedma, void

Differential Revision: https://reviews.llvm.org/D142923

(cherry picked from commit 1cecfa407c1a1a114d75c8b85fbe97e4c1275c1f)

  Commit: d73eb820244b7b02e95ee3e47238f6f6527180c5
      https://github.com/llvm/llvm-project/commit/d73eb820244b7b02e95ee3e47238f6f6527180c5
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/lib/CodeGen/IfConversion.cpp
    M llvm/test/CodeGen/ARM/inlineasmbr-if-cvt.mir

  Log Message:
  -----------
  [llvm][IfConversion] update successor list when merging INLINEASM_BR

If this successor list is not correct, then branch-folding may
incorrectly think that the indirect target is dead and remove it. This
results in a dangling reference to the removed block as an operand to
the INLINEASM_BR, which later will get AsmPrinted into code that doesn't
assemble.

This was made more obvious by, but is not a regression of
https://reviews.llvm.org/D130316.

Fixes: https://github.com/llvm/llvm-project/issues/60346

Reviewed By: efriedma, void

Differential Revision: https://reviews.llvm.org/D142924

(cherry picked from commit 07c7784d7bf69b9944b92ecc283cac823bcfce16)

  Commit: f7fabe48ac7874b08396cba2305dbc63c63642b9
      https://github.com/llvm/llvm-project/commit/f7fabe48ac7874b08396cba2305dbc63c63642b9
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/tools/lto/CMakeLists.txt
    R llvm/tools/lto/lto.dylib.exports
    M llvm/tools/lto/lto.exports

  Log Message:
  -----------
  libLTO.{so,dylib}: remove unused non-LTO symbols

These dissembler symbols are not used by LTO (see Apple ld64's use
in check-llvm-tools-lto). On ELF platforms, these symbols are not defined and are
rejected by ld --no-undefined-version.

I think this is a more proper solution than D139932 and this fixes
-DBUILD_SHARED_LIBS=on for ELF as well.

(cherry picked from commit c294bdd64768e0954e7dec8ed878bdac7ce7530f)

  Commit: 287c362d1f7ee8cc88eb4d5c96f2ecb0ee971fe6
      https://github.com/llvm/llvm-project/commit/287c362d1f7ee8cc88eb4d5c96f2ecb0ee971fe6
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/tools/remarks-shlib/CMakeLists.txt
    R llvm/tools/remarks-shlib/Remarks.dylib.exports

  Log Message:
  -----------
  libRemarks.{so,dylib}: remove Remarks.dylib.exports

Remarks.exports is only intended for NOT (BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB)
builds.

For (unintended use case) BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB (the latter
is used by some Linux distros), the library defines just one symbol on ELF.
There is no need to use a version script.

I think this is a more proper solution than D139932 and fixes `symbol not
defined` errors after lld default change D135402.

(cherry picked from commit bf07de38b05e4c952beb4009aa15060d0e4f7cc7)

  Commit: 6b68e3c87638b82cf34dbe9397ae73fb3ecd7c09
      https://github.com/llvm/llvm-project/commit/6b68e3c87638b82cf34dbe9397ae73fb3ecd7c09
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/test/CodeGen/RISCV/sextw-removal.ll

  Log Message:
  -----------
  [RISCV] Precommit a test for upcoming miscompile bugfix

(cherry picked from commit 604cc68b587d8b8a90bd1a0aecfbc7bd3021e926)

  Commit: fe29755f9ccf5243439b156d35be330c3389d4a1
      https://github.com/llvm/llvm-project/commit/fe29755f9ccf5243439b156d35be330c3389d4a1
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVSExtWRemoval.cpp
    M llvm/test/CodeGen/RISCV/sextw-removal.ll

  Log Message:
  -----------
  [RISCV] Fix miscompile in SExtWRemoval due to early return ignoring other sources

This code is walking back through a worklist of sources. All of the sources need to be sign extending for the result to be true. We had a case which returned rather than continued, which causes a miscompile when another source was not sign extended. The flawed logic was introduced in Dec 22, by change 844430bcc377.

This was recently exposed in a stage2 build of llvm-tablegen when we switched from using llvm::Optional to std::optional. The stars aligned in just the wrong way, and we started actively miscompiling idiomatic optional usage. std::optional<uint32_t> appears to use the top 32 bits of the word on RV64 for its tag.

Differential Revision: https://reviews.llvm.org/D143594

(cherry picked from commit db6bee5fec0d7fdfc18005c5c5ccd15f1ede945d)

  Commit: 5036912174acb051468611a25f1b43b4e8336be9
      https://github.com/llvm/llvm-project/commit/5036912174acb051468611a25f1b43b4e8336be9
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M mlir/CMakeLists.txt

  Log Message:
  -----------
  Add `set(CMAKE_CXX_STANDARD 17)` to MLIR CMakeLists.txt

This is only useful when building the project in a "standalone" way: that is by
invoking cmake pointing at mlir/ to build against an already built LLVM.

Fixes #60574

Compare: https://github.com/llvm/llvm-project/compare/434575c026c8...5036912174ac