[all-commits] [llvm/llvm-project] 851a89: [mlir][llvm] Purge struct_attr

Christian Ulmann via All-commits all-commits at lists.llvm.org
Thu Feb 9 00:42:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 851a89715cadf411bd66a7cbb9d7567580f08f4c
      https://github.com/llvm/llvm-project/commit/851a89715cadf411bd66a7cbb9d7567580f08f4c
  Author: Christian Ulmann <christian.ulmann at nextsilicon.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Conversion/FuncToLLVM/emit-c-wrappers-for-external-callers.mlir
    M mlir/test/Conversion/FuncToLLVM/emit-c-wrappers-for-external-functions.mlir
    M mlir/test/Dialect/LLVMIR/invalid.mlir

  Log Message:
  -----------
  [mlir][llvm] Purge struct_attr

This commit removes the `llvm.struct_attr` which was used to bundle
result attributes that were previously attached to multiple results.
This extension isn't part of LLVM as result attribute semantics cannot
be supported on a struct field granularity.
Furthermore, many usages promoted result attributes to argument
attributes but this does not necessary preserve the semantics.

Reviewed By: gysit

Differential Revision: https://reviews.llvm.org/D143473




More information about the All-commits mailing list