[all-commits] [llvm/llvm-project] 8c469d: [SanitizerBinaryMetadata] Make constructors/destru...

[Marco Elver via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c469d1693895e2cf7bf8b65b31184e9e4716c8f
      https://github.com/llvm/llvm-project/commit/8c469d1693895e2cf7bf8b65b31184e9e4716c8f
  Author: Marco Elver <elver at google.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/SanitizerBinaryMetadata.cpp
    M llvm/test/Instrumentation/SanitizerBinaryMetadata/ctor.ll

  Log Message:
  -----------
  [SanitizerBinaryMetadata] Make constructors/destructors hidden

By switching them to external with default visibility, DSOs may not call
their own constructor/destructor. This is incorrect, because they pass
different parameters.

Fix it by marking the ctors/dtors as external linkage but with hidden
visibility.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D143611