[all-commits] [llvm/llvm-project] dc6f8e: [ELF] Reword symMap/symVector comment. NFC

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Feb 8 10:50:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc6f8ef57c8202fab4fcd6de875fbec17865f247
      https://github.com/llvm/llvm-project/commit/dc6f8ef57c8202fab4fcd6de875fbec17865f247
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M lld/ELF/SymbolTable.h

  Log Message:
  -----------
  [ELF] Reword symMap/symVector comment. NFC

Having symVector makes iteration efficient and is actually more
efficient than using llvm::DenseMap<llvm::CachedHashStringRef, Symbol
*>, so the FIXME comment can be removed. Using an alternative
implementation ankerl/unordered_dense.h decreases link time for chromium
by 0.x% but I am unsure it justifies the extra header file.




More information about the All-commits mailing list