[all-commits] [llvm/llvm-project] 37eb9d: Revert "[Support] change StringMap hash function f...

[erikdesjardins via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 37eb9d13f891f7656f811516e765b929b169afe0
      https://github.com/llvm/llvm-project/commit/37eb9d13f891f7656f811516e765b929b169afe0
  Author: Erik Desjardins <erikdesjardinspublic at gmail.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M clang-tools-extra/test/modularize/ProblemsDisplayLists.modularize
    M clang/unittests/Basic/SarifTest.cpp
    M compiler-rt/test/profile/Linux/instrprof-show-debug-info-correlation.c
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M llvm/lib/Support/StringMap.cpp
    M llvm/test/DebugInfo/Generic/accel-table-hash-collisions.ll
    M llvm/test/DebugInfo/Generic/debug-names-hash-collisions.ll
    M llvm/test/DebugInfo/X86/debug-pubtables-dwarf64.ll
    M llvm/test/DebugInfo/X86/gnu-public-names-gmlt.ll
    M llvm/test/DebugInfo/X86/gnu-public-names.ll
    M llvm/test/tools/dsymutil/ARM/extern-alias.test
    M llvm/test/tools/llvm-profdata/suppl-instr-with-sample.test
    M mlir/test/mlir-lsp-server/completion.test

  Log Message:
  -----------
  Revert "[Support] change StringMap hash function from djbHash to xxHash"

This reverts commit d768b97424f9e1a0aae45440a18b99f21c4027ce.

Causes sanitizer failure: https://lab.llvm.org/buildbot/#/builders/238/builds/1114

```
/b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Support/xxhash.cpp:107:12: runtime error: applying non-zero offset 8 to null pointer
    #0 0xaaaab28ec6c8 in llvm::xxHash64(llvm::StringRef) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Support/xxhash.cpp:107:12
    #1 0xaaaab28cbd38 in llvm::StringMapImpl::LookupBucketFor(llvm::StringRef) /b/sanitizer-aarch64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/Support/StringMap.cpp:87:28
```

Probably causes test failure in `warn-unsafe-buffer-usage-fixits-local-var-span.cpp`: https://lab.llvm.org/buildbot/#/builders/60/builds/10619

Probably causes reverse-iteration test failure in `test-output-format.ll`: https://lab.llvm.org/buildbot/#/builders/54/builds/3545