[all-commits] [llvm/llvm-project] d768b9: [Support] change StringMap hash function from djbH...

erikdesjardins via All-commits all-commits at lists.llvm.org
Tue Feb 7 21:09:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d768b97424f9e1a0aae45440a18b99f21c4027ce
      https://github.com/llvm/llvm-project/commit/d768b97424f9e1a0aae45440a18b99f21c4027ce
  Author: Erik Desjardins <erikdesjardinspublic at gmail.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M clang-tools-extra/test/modularize/ProblemsDisplayLists.modularize
    M clang/unittests/Basic/SarifTest.cpp
    M compiler-rt/test/profile/Linux/instrprof-show-debug-info-correlation.c
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M llvm/lib/Support/StringMap.cpp
    M llvm/test/DebugInfo/Generic/accel-table-hash-collisions.ll
    M llvm/test/DebugInfo/Generic/debug-names-hash-collisions.ll
    M llvm/test/DebugInfo/X86/debug-pubtables-dwarf64.ll
    M llvm/test/DebugInfo/X86/gnu-public-names-gmlt.ll
    M llvm/test/DebugInfo/X86/gnu-public-names.ll
    M llvm/test/tools/dsymutil/ARM/extern-alias.test
    M llvm/test/tools/llvm-profdata/suppl-instr-with-sample.test
    M mlir/test/mlir-lsp-server/completion.test

  Log Message:
  -----------
  [Support] change StringMap hash function from djbHash to xxHash

Depends on https://reviews.llvm.org/D142861.

Alternative to https://reviews.llvm.org/D137601.

xxHash is much faster than djbHash. This makes a simple Rust test case with a large constant string 10% faster to compile.

Previous attempts at changing this hash function (e.g. https://reviews.llvm.org/D97396) had to be reverted due to breaking tests that depended on iteration order.
No additional tests fail with this patch compared to `main` when running `check-all` with `-DLLVM_ENABLE_PROJECTS="all"` (on a Linux host), so I hope I found everything that needs to be changed.

Differential Revision: https://reviews.llvm.org/D142862




More information about the All-commits mailing list