[all-commits] [llvm/llvm-project] 1fbccf: [mlir][IRNumbering] Fix the dialect comparator to ...

River Riddle via All-commits all-commits at lists.llvm.org
Tue Feb 7 18:09:16 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1fbccfd69324f08f067ca5534abc67d32cad75ed
      https://github.com/llvm/llvm-project/commit/1fbccfd69324f08f067ca5534abc67d32cad75ed
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M mlir/lib/Bytecode/Writer/IRNumbering.cpp

  Log Message:
  -----------
  [mlir][IRNumbering] Fix the dialect comparator to be strict

Check if rhs is the dialect to be ordered first, ensuring that
we don't inadvertantly order something before it by
falling back to pure number comparison.

This only shows up depending on the implementation of
stable_sort. This was hit in a build of MSVC that was
checking for strict ordering.




More information about the All-commits mailing list