[all-commits] [llvm/llvm-project] dc3d0b: [lit] don't skip test times when executions are in...

Ashay Rane via All-commits all-commits at lists.llvm.org
Tue Feb 7 11:28:27 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc3d0b266bd9b4c15cef3ed92ab1b60742a80188
      https://github.com/llvm/llvm-project/commit/dc3d0b266bd9b4c15cef3ed92ab1b60742a80188
  Author: Ashay Rane <ashay at users.noreply.github.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M llvm/utils/lit/lit/TestTimes.py

  Log Message:
  -----------
  [lit] don't skip test times when executions are instantaneous

If a test executes quickly or if the timing resolution is too coarse,
the running time associated with a test could be zero. This happens
often for the //llvm/utils/lit/tests/reorder.py test on Windows, which
causes the test to fail non-deterministically.

This patch modifies the existing check, so that instead of skipping
zeros, lit now skips if the timing is None (presumably due to an error
in measurement). Recurring executions of the reorder.py test on Windows
seem to indicate that the test no longer exhibits occasional failure.

Reviewed By: stella.stamenova

Differential Revision: https://reviews.llvm.org/D143504




More information about the All-commits mailing list