[all-commits] [llvm/llvm-project] 1cecfa: precommit test for pr60346

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Tue Feb 7 10:28:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1cecfa407c1a1a114d75c8b85fbe97e4c1275c1f
      https://github.com/llvm/llvm-project/commit/1cecfa407c1a1a114d75c8b85fbe97e4c1275c1f
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    A llvm/test/CodeGen/ARM/inlineasmbr-if-cvt.mir

  Log Message:
  -----------
  precommit test for pr60346

Link: https://github.com/llvm/llvm-project/issues/60346

Reviewed By: efriedma, void

Differential Revision: https://reviews.llvm.org/D142923


  Commit: 07c7784d7bf69b9944b92ecc283cac823bcfce16
      https://github.com/llvm/llvm-project/commit/07c7784d7bf69b9944b92ecc283cac823bcfce16
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M llvm/lib/CodeGen/IfConversion.cpp
    M llvm/test/CodeGen/ARM/inlineasmbr-if-cvt.mir

  Log Message:
  -----------
  [llvm][IfConversion] update successor list when merging INLINEASM_BR

If this successor list is not correct, then branch-folding may
incorrectly think that the indirect target is dead and remove it. This
results in a dangling reference to the removed block as an operand to
the INLINEASM_BR, which later will get AsmPrinted into code that doesn't
assemble.

This was made more obvious by, but is not a regression of
https://reviews.llvm.org/D130316.

Fixes: https://github.com/llvm/llvm-project/issues/60346

Reviewed By: efriedma, void

Differential Revision: https://reviews.llvm.org/D142924


Compare: https://github.com/llvm/llvm-project/compare/775687bc4147...07c7784d7bf6


More information about the All-commits mailing list