[all-commits] [llvm/llvm-project] b716bf: [mlir][scf] Fix builder of WhileOp with region bui...

[Ingo Müller via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b716bf84eaba25e0f83d1778288f65a671e85f98
      https://github.com/llvm/llvm-project/commit/b716bf84eaba25e0f83d1778288f65a671e85f98
  Author: Ingo Müller <ingomueller at google.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M mlir/lib/Dialect/SCF/IR/SCF.cpp
    A mlir/test/Dialect/SCF/while-op-builder.mlir
    M mlir/test/lib/Dialect/SCF/CMakeLists.txt
    A mlir/test/lib/Dialect/SCF/TestWhileOpBuilder.cpp
    M mlir/tools/mlir-opt/mlir-opt.cpp

  Log Message:
  -----------
  [mlir][scf] Fix builder of WhileOp with region builder arguments.

The overload of WhileOp::build with arguments for builder functions for
the regions of the op was broken: It did not compute correctly the types
(and locations) of the region arguments, which lead to failed assertions
when the result types were different from the operand types.
Specifically, it used the result types (and operand locations) for *both*
regions, instead of the operand types (and locations) for the 'before'
region and the result types (and loecations) for the 'after' region.

Reviewed By: Mogball, mehdi_amini

Differential Revision: https://reviews.llvm.org/D142952