[all-commits] [llvm/llvm-project] 239949: [debug-info] Followup to e0374fb2f4, avoid changin...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2399497c9d68c946764e3089fb0b4c8d29166d67
      https://github.com/llvm/llvm-project/commit/2399497c9d68c946764e3089fb0b4c8d29166d67
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M llvm/lib/Transforms/Utils/SSAUpdater.cpp

  Log Message:
  -----------
  [debug-info] Followup to e0374fb2f4, avoid changing codegen

As discussed on D140404, calling GetValueInMiddleOfBlock can force PHI
nodes to be created, but the patch was only supposed to fetch a Value if it
wasn't going to generate any PHIs. Fix this by using GetValueAtEndOfBlock
instead of the Middle variant, which was the original intention given the
check of HasValueForBlock.

We don't need to consider the "middle of block" scenario as we're only
dealing with blocks where there are no value definitions.