[all-commits] [llvm/llvm-project] c8482d: [BOLT] Reintroduce allow-stripped

[Amir Ayupov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c8482da779a9cd5fa34c094639942ab4eb515cc1
      https://github.com/llvm/llvm-project/commit/c8482da779a9cd5fa34c094639942ab4eb515cc1
  Author: Amir Ayupov <aaupov at fb.com>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M bolt/lib/Rewrite/RewriteInstance.cpp
    M bolt/test/X86/broken_dynsym.test
    M bolt/test/X86/is-strip.s

  Log Message:
  -----------
  [BOLT] Reintroduce allow-stripped

Reject stripped binaries as a policy.

The core issue with stripped binaries is that we can't detect the presence
of split functions which require extra handling. Therefore BOLT can't ensure
functional correctness of produced binary if the input stripped binary contains
split functions. Supporting such cases is an interesting problem but it goes
against BOLT's intended goal of achieving peak program performance.

Reviewed By: maksfb

Differential Revision: https://reviews.llvm.org/D142686