[all-commits] [llvm/llvm-project] 6c8fe9: [Support] Move ItaniumManglingCanonicalizer and Sy...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c8fe96582362ebff9f466dcf8a8d76b06641de2
      https://github.com/llvm/llvm-project/commit/6c8fe96582362ebff9f466dcf8a8d76b06641de2
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M clang/docs/tools/clang-formatted-files.txt
    A llvm/include/llvm/ProfileData/ItaniumManglingCanonicalizer.h
    M llvm/include/llvm/ProfileData/SampleProfReader.h
    A llvm/include/llvm/ProfileData/SymbolRemappingReader.h
    R llvm/include/llvm/Support/ItaniumManglingCanonicalizer.h
    R llvm/include/llvm/Support/SymbolRemappingReader.h
    M llvm/lib/ProfileData/CMakeLists.txt
    M llvm/lib/ProfileData/InstrProfReader.cpp
    A llvm/lib/ProfileData/ItaniumManglingCanonicalizer.cpp
    A llvm/lib/ProfileData/SymbolRemappingReader.cpp
    M llvm/lib/Support/CMakeLists.txt
    R llvm/lib/Support/ItaniumManglingCanonicalizer.cpp
    R llvm/lib/Support/SymbolRemappingReader.cpp
    M llvm/tools/llvm-cxxmap/CMakeLists.txt
    M llvm/tools/llvm-cxxmap/llvm-cxxmap.cpp
    M llvm/unittests/ProfileData/CMakeLists.txt
    A llvm/unittests/ProfileData/ItaniumManglingCanonicalizerTest.cpp
    A llvm/unittests/ProfileData/SymbolRemappingReaderTest.cpp
    M llvm/unittests/Support/CMakeLists.txt
    R llvm/unittests/Support/ItaniumManglingCanonicalizerTest.cpp
    R llvm/unittests/Support/SymbolRemappingReaderTest.cpp
    M llvm/utils/gn/secondary/llvm/lib/ProfileData/BUILD.gn
    M llvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn
    M llvm/utils/gn/secondary/llvm/tools/llvm-cxxmap/BUILD.gn
    M llvm/utils/gn/secondary/llvm/unittests/ProfileData/BUILD.gn
    M llvm/utils/gn/secondary/llvm/unittests/Support/BUILD.gn
    M utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

  Log Message:
  -----------
  [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

As mentioned on https://discourse.llvm.org/t/issues-in-llvm-tblgen-high-parallelized-build/68037, ItaniumManglingCanonicalizer is often slow to build, resulting in a bottleneck for distributed builds while waiting for LLVMSupport to complete.

SymbolRemappingReader is the only current user of ItaniumManglingCanonicalizer, and this is only used by ProfileData and llvm-cxxmap - so I propose we move both files into the ProfileData library.

Differential Revision: https://reviews.llvm.org/D143318