[all-commits] [llvm/llvm-project] d8f576: [ELF] -z notext: avoid dynamic relocations in .eh_...
Fangrui Song via All-commits
all-commits at lists.llvm.org
Mon Feb 6 10:46:01 PST 2023
Branch: refs/heads/release/16.x
Home: https://github.com/llvm/llvm-project
Commit: d8f5768305dcb2521b20c364c5bb304ec7a1c064
https://github.com/llvm/llvm-project/commit/d8f5768305dcb2521b20c364c5bb304ec7a1c064
Author: Fangrui Song <i at maskray.me>
Date: 2023-02-06 (Mon, 06 Feb 2023)
Changed paths:
M lld/ELF/Relocations.cpp
A lld/test/ELF/eh-frame-znotext.s
Log Message:
-----------
[ELF] -z notext: avoid dynamic relocations in .eh_frame
Fix https://github.com/llvm/llvm-project/issues/60392
```
// a.cc
void raise() { throw 42; }
bool foo() {
try { raise(); } catch (int) { return true; }
return false;
}
int main() { foo(); }
```
```
clang++ --target=x86_64-linux-gnu -fno-pic -mcmodel=large -no-pie -fuse-ld=lld -z notext a.cc -o a && ./a
clang++ --target=aarch64-linux-gnu -fno-pic -no-pie -fuse-ld=lld -Wl,--dynamic-linker=/usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 -Wl,-rpath=/usr/aarch64-linux-gnu/lib -z notext a.cc -o a && ./a
```
Both commands fail because we produce a dynamic relocation for
R_X86_64_64/R_AARCH64_ABS64 in .eh_frame which will be adjusted to a wrong
offset by `SectionBase::getOffset` after D122459.
Since GNU ld uses a canonical PLT entry instead of a dynamic relocation for
.eh_frame, we follow suit as well to avoid the issue.
Mips has an ABI issue (https://github.com/llvm/llvm-project/issues/5837) and we
don't implement GNU ld's DW_EH_PE_absptr conversion. mips64-eh-abs-reloc.s wants
a dynamic relocation, so keep the original behavior for EM_MIPS.
Differential Revision: https://reviews.llvm.org/D143136
(cherry picked from commit 08c915fa76ef91efa16df0676ed69e4fb360989f)
More information about the All-commits
mailing list