[all-commits] [llvm/llvm-project] 121452: [DebugInfo] Handle fixed-width DW_FORM_addrx varia...

[Benjamin Maxwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 121452aa50afe99f56bffc1086016f3ceedd20e6
      https://github.com/llvm/llvm-project/commit/121452aa50afe99f56bffc1086016f3ceedd20e6
  Author: Benjamin Maxwell <benjamin.maxwell at arm.com>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
    M llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp
    M llvm/unittests/DebugInfo/DWARF/DwarfGenerator.h

  Log Message:
  -----------
  [DebugInfo] Handle fixed-width DW_FORM_addrx variants in DWARFFormValue::getAsSectionedAddress()

Previously this would incorrectly return the raw offset into the .debug_addr section for the
DW_FORM_addrx1/2/3/4 forms rather than the actual address.

Note that this was handled correctly in the dump() function so this issue only occurs for users
of this API and not in tools such as llvm-dwarfdump. The dump() method has now been updated
to use this method to increase coverage.

This also now adds a few unit tests for indexed addresses to DWARFDebugInfoTest.

Differential Revision: https://reviews.llvm.org/D143073