[all-commits] [llvm/llvm-project] 858329: [libc] Do not install to the default triple in GPU...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Jan 27 12:06:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8583291dfc43f5769291d8e70d84125154e61341
      https://github.com/llvm/llvm-project/commit/8583291dfc43f5769291d8e70d84125154e61341
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M libc/lib/CMakeLists.txt

  Log Message:
  -----------
  [libc] Do not install to the default triple in GPU mode

Currently this logic causes the `libcgpu.a` to be installed to the
user's default triple. The GPU target isn't really true to this in a
cross-compiling sense so we should just default to the regular `/lib`
directory

Reviewed By: sivachandra, lntue

Differential Revision: https://reviews.llvm.org/D142774


  Commit: feedb4ad7d305c5864127e2b27ae650e8f04fc58
      https://github.com/llvm/llvm-project/commit/feedb4ad7d305c5864127e2b27ae650e8f04fc58
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-01-27 (Fri, 27 Jan 2023)

  Changed paths:
    M libc/cmake/modules/prepare_libc_gpu_build.cmake

  Log Message:
  -----------
  [libc] Add code for detecting NVIDIA GPUs as well

Recently the `nvptx-arch` tool was added to address the lack of a
similar tool for detecting locally installed NVIDIA GPUs. This patch
adds similar functionality for the already existing `amdgpu-arch` tool
in libc. These will be used to run tests on the user's system in the
future. On a system with both GPUs installed we will just go with the
first GPU detected. In the future we may want to configure the tests to
run on both of them.

Reviewed By: sivachandra, lntue

Differential Revision: https://reviews.llvm.org/D142776


Compare: https://github.com/llvm/llvm-project/compare/057a2c239e80...feedb4ad7d30


More information about the All-commits mailing list