[all-commits] [llvm/llvm-project] cb4ccd: [mlir][Conversion] Rename the MemRefToLLVM pass
qcolombet via All-commits
all-commits at lists.llvm.org
Fri Jan 27 01:37:11 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: cb4ccd38fa0407928feed7e39d197169eabc95b2
https://github.com/llvm/llvm-project/commit/cb4ccd38fa0407928feed7e39d197169eabc95b2
Author: Quentin Colombet <quentin.colombet at gmail.com>
Date: 2023-01-27 (Fri, 27 Jan 2023)
Changed paths:
M mlir/docs/TargetLLVMIR.md
M mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp
M mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp
M mlir/include/mlir/Conversion/MemRefToLLVM/MemRefToLLVM.h
M mlir/include/mlir/Conversion/Passes.td
M mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
M mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
M mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
M mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
M mlir/lib/Dialect/SparseTensor/Pipelines/SparseTensorPipelines.cpp
M mlir/test/Conversion/FuncToLLVM/calling-convention.mlir
M mlir/test/Conversion/MemRefToLLVM/convert-alloca-scope.mlir
M mlir/test/Conversion/MemRefToLLVM/convert-dynamic-memref-ops.mlir
M mlir/test/Conversion/MemRefToLLVM/convert-static-memref-ops.mlir
M mlir/test/Conversion/MemRefToLLVM/expand-then-convert-to-llvm.mlir
M mlir/test/Conversion/MemRefToLLVM/generic-functions.mlir
M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir
M mlir/test/Integration/Dialect/Async/CPU/microbench-linalg-async-parallel-for.mlir
M mlir/test/Integration/Dialect/Async/CPU/microbench-scf-async-parallel-for.mlir
M mlir/test/Integration/Dialect/Async/CPU/test-async-parallel-for-1d.mlir
M mlir/test/Integration/Dialect/Async/CPU/test-async-parallel-for-2d.mlir
M mlir/test/Integration/Dialect/Complex/CPU/correctness.mlir
M mlir/test/Integration/Dialect/LLVMIR/CPU/test-complex-sparse-constant.mlir
M mlir/test/Integration/Dialect/LLVMIR/CPU/test-vp-intrinsic.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/matmul-vs-matvec.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/rank-reducing-subview.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-collapse-tensor.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-1d-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-1d-nwc-wcf-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-2d-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-2d-nhwc-hwcf-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-3d-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-3d-ndhwc-dhwcf-call.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-elementwise.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-expand-tensor.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-one-shot-bufferize.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-padtensor.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-subtensor-insert-multiple-uses.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-subtensor-insert.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-tensor-e2e.mlir
M mlir/test/Integration/Dialect/Linalg/CPU/test-tensor-matmul.mlir
M mlir/test/Integration/Dialect/Memref/cast-runtime-verification.mlir
M mlir/test/Integration/Dialect/Memref/memref_abi.c
M mlir/test/Integration/Dialect/Standard/CPU/test-ceil-floor-pos-neg.mlir
M mlir/test/Integration/Dialect/Standard/CPU/test_subview.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-mulf-full.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-mulf.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli-ext.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli-full.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-tilezero-block.mlir
M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-tilezero.mlir
M mlir/test/Integration/Dialect/Vector/CPU/ArmSVE/test-sve.mlir
M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-inline-asm-vector-avx512.mlir
M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-sparse-dot-product.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-0-d-vectors.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-compress.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-expand.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-gather.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-maskedload.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-maskedstore.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-realloc.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-scatter.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-sparse-dot-matvec.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-sparse-saxpy-jagged-matvec.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-1d.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-2d.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-3d.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-to-loops.mlir
M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-write.mlir
M mlir/test/lib/Dialect/LLVM/TestLowerToLLVM.cpp
M mlir/test/mlir-cpu-runner/async-value.mlir
M mlir/test/mlir-cpu-runner/async.mlir
M mlir/test/mlir-cpu-runner/bare-ptr-call-conv.mlir
M mlir/test/mlir-cpu-runner/copy.mlir
M mlir/test/mlir-cpu-runner/global-memref.mlir
M mlir/test/mlir-cpu-runner/memref-reinterpret-cast.mlir
M mlir/test/mlir-cpu-runner/memref-reshape.mlir
M mlir/test/mlir-cpu-runner/sgemm-naive-codegen.mlir
M mlir/test/mlir-cpu-runner/unranked-memref.mlir
M mlir/test/mlir-cpu-runner/utils.mlir
M mlir/test/mlir-opt/async.mlir
M mlir/test/python/execution_engine.py
M mlir/test/python/integration/dialects/linalg/opsrun.py
M mlir/tools/mlir-vulkan-runner/mlir-vulkan-runner.cpp
M mlir/unittests/ExecutionEngine/Invoke.cpp
Log Message:
-----------
[mlir][Conversion] Rename the MemRefToLLVM pass
Since the recent MemRef refactoring that centralizes the lowering of
complex MemRef operations outside of the conversion framework, the
MemRefToLLVM pass doesn't directly convert these complex operations.
Instead, to fully convert the whole MemRef dialect space, MemRefToLLVM
needs to run after `expand-strided-metadata`.
Make this more obvious by changing the name of the pass and the option
associated with it from `convert-memref-to-llvm` to
`finalize-memref-to-llvm`.
The word "finalize" conveys that this pass needs to run after something
else and that something else is documented in its tablegen description.
This is a follow-up patch related to the conversation at:
https://discourse.llvm.org/t/psa-you-need-to-run-expand-strided-metadata-before-memref-to-llvm-now/66956/14
Differential Revision: https://reviews.llvm.org/D142463
More information about the All-commits
mailing list