[all-commits] [llvm/llvm-project] dc682e: [test][lldb-vscode] Fix unclean shutdown in test_t...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Thu Jan 26 14:30:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc682ed590f73f7b7417ecf66d18b303ab957c62
      https://github.com/llvm/llvm-project/commit/dc682ed590f73f7b7417ecf66d18b303ab957c62
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

  Log Message:
  -----------
  [test][lldb-vscode] Fix unclean shutdown in test_terminate_commands

This test manually sends `terminateCommands` to shutdown, but then the test attempts another `terminateCommands` request in test tear down, which fails since it's already torn down. This error is ignored in LLDB's old fork of unittest2, but will be reported as a test failure in `unittest` from the Python standard library. Use `disconnectAutomatically` to avoid terminating twice.




More information about the All-commits mailing list