[all-commits] [llvm/llvm-project] 42e371: [NFC][Concepts] Change the Source Range of Concept...

Erich Keane via All-commits all-commits at lists.llvm.org
Thu Jan 26 11:14:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 42e371b174d4407ec5805010c2ecfef9c086b5c2
      https://github.com/llvm/llvm-project/commit/42e371b174d4407ec5805010c2ecfef9c086b5c2
  Author: Erich Keane <erich.keane at intel.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M clang/lib/Sema/SemaConcept.cpp

  Log Message:
  -----------
  [NFC][Concepts] Change the Source Range of Concepts ParamMatching

As came up in the discussion on
https://reviews.llvm.org/rG12cb1cb3720de8d164196010123ce1a8901d8122

We were asserting because the attempt to print a note found that our
source range for a immediately declared constraint (as a part of
Parameter Mapping Substitution) wasn't in order.

However, it doesn't really make sense to have the location of this be
the whole list of template arguments, as that would result in the range
being:
bool func(std::thing<char*> auto foo) {}
                     ^^^^^^^^^^^^^^^

Even if done correctly.  Instead, this patch makes the range be just
'foo' in this case (or a pointer right after 'auto' if unnamed).




More information about the All-commits mailing list