[all-commits] [llvm/llvm-project] 787876: [unittests] Use GTEST_SKIP() instead of return whe...

Paul T Robinson via All-commits all-commits at lists.llvm.org
Thu Jan 26 08:40:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 787876b0d592a6b4e87d00a0adb89ce87dfc11cd
      https://github.com/llvm/llvm-project/commit/787876b0d592a6b4e87d00a0adb89ce87dfc11cd
  Author: Paul Robinson <paul.robinson at sony.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M clang/unittests/AST/StructuralEquivalenceTest.cpp
    M clang/unittests/Driver/ToolChainTest.cpp
    M clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp

  Log Message:
  -----------
  [unittests] Use GTEST_SKIP() instead of return when appropriate

Basically NFC: A TEST/TEST_F/etc that bails out early (usually because
setup failed or some other runtime condition wasn't met) generally
should use GTEST_SKIP() to report its status correctly, unless it
takes steps to report another status (e.g., FAIL()).




More information about the All-commits mailing list