[all-commits] [llvm/llvm-project] 26b79c: [SVE] Fix incorrect lowering of predicate permute ...

[paulwalker-arm via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26b79ca3fafc525225090646d42837368b3763c3
      https://github.com/llvm/llvm-project/commit/26b79ca3fafc525225090646d42837368b3763c3
  Author: Paul Walker <paul.walker at arm.com>
  Date:   2023-01-26 (Thu, 26 Jan 2023)

  Changed paths:
    M clang/include/clang/Basic/arm_sve.td
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_rev.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_trn1.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_trn2.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_uzp1.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_uzp2.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_zip1.c
    M clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_zip2.c
    M llvm/include/llvm/IR/IntrinsicsAArch64.td
    M llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
    M llvm/lib/Target/AArch64/SVEInstrFormats.td
    M llvm/test/CodeGen/AArch64/sve-intrinsics-perm-select.ll

  Log Message:
  -----------
  [SVE] Fix incorrect lowering of predicate permute builtins.

When lowering predicate permute builtins we incorrectly assume only
the typically "active" bits for the specified element type play a
role with all other bits zero'd.  This is not the case because all
bits are significant, with the element type specifying how they
are grouped:

  b8  - permute using a block size of 1 bit
  b16 - permute using a block size of 2 bits
  b32 - permute using a block size of 4 bits
  b64 - permute using a block size of 8 bits

The affected builtins are svrev, svtrn1, svtrn2, svuzp1, svuzp2,
svzip1 and svzip2.

This patch adds new intrinsics to support these operations and
changes the builtin lowering code to emit them.  The b8 case remains
unchanged because for that operation the existing intrinsics work
as required and their support for other predicate types has been
maintained as useful if only as a way to test the correctness of
their matching ISD nodes that code generation relies on.

Differential Revision: https://reviews.llvm.org/D142065