[all-commits] [llvm/llvm-project] afa764: [libc] add scanf current position conversion

michaelrj-google via All-commits all-commits at lists.llvm.org
Wed Jan 25 15:29:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: afa764c9a6d68ab6de94a5d007e0b468e65ae946
      https://github.com/llvm/llvm-project/commit/afa764c9a6d68ab6de94a5d007e0b468e65ae946
  Author: Michael Jones <michaelrj at google.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M libc/src/stdio/scanf_core/CMakeLists.txt
    M libc/src/stdio/scanf_core/converter.cpp
    A libc/src/stdio/scanf_core/converter_utils.h
    A libc/src/stdio/scanf_core/current_pos_converter.h
    M libc/src/stdio/scanf_core/float_converter.cpp
    M libc/src/stdio/scanf_core/int_converter.cpp
    M libc/src/stdio/scanf_core/scanf_main.cpp
    M libc/test/src/stdio/sscanf_test.cpp

  Log Message:
  -----------
  [libc] add scanf current position conversion

To add the current position (%n) conversion, some reorganization needed
to be done. The "write a number to this pointer using the length
modifier" utilities and a couple other shared parsing functions have
been moved into converter_utils.h. This made implementing
current_pos_converter very simple.

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D142495


  Commit: edf964e0ddfb98cf4ac849fa87bcc58a4d86a89e
      https://github.com/llvm/llvm-project/commit/edf964e0ddfb98cf4ac849fa87bcc58a4d86a89e
  Author: Michael Jones <michaelrj at google.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M libc/src/stdio/scanf_core/CMakeLists.txt
    M libc/src/stdio/scanf_core/converter.cpp
    M libc/src/stdio/scanf_core/converter_utils.h
    M libc/src/stdio/scanf_core/int_converter.cpp
    A libc/src/stdio/scanf_core/ptr_converter.cpp
    A libc/src/stdio/scanf_core/ptr_converter.h
    M libc/test/src/stdio/sscanf_test.cpp

  Log Message:
  -----------
  [libc] add scanf pointer conversion

This patch adds the last conversion for scanf, %p. It is set up to match
the %p implementation in our printf.

Reviewed By: sivachandra, lntue

Differential Revision: https://reviews.llvm.org/D142510


Compare: https://github.com/llvm/llvm-project/compare/68e7c00b03cf...edf964e0ddfb


More information about the All-commits mailing list