[all-commits] [llvm/llvm-project] 1799a7: [llvm-ml] Disallow '{' and '}' at the start of a s...

Sergei Barannikov via All-commits all-commits at lists.llvm.org
Wed Jan 25 09:44:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1799a714a7a77ba6feaf33e09c554c6127ebbae6
      https://github.com/llvm/llvm-project/commit/1799a714a7a77ba6feaf33e09c554c6127ebbae6
  Author: Sergei Barannikov <barannikov88 at gmail.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M llvm/lib/MC/MCParser/MasmParser.cpp
    A llvm/test/tools/llvm-ml/label_errors.asm

  Log Message:
  -----------
  [llvm-ml] Disallow '{' and '}' at the start of a statement

'{', '}' and (conditionally) '*' were allowed at the start of a
statement. This behavior was copied from AsmParser, where they were
added to support Hexagon bundles (braces) and BFP memory instructions
(the star).
MASM dialect is x86-specific and does not allow these symbols to be
used at the beginning of an instruction.

Worth noting that '{' is a valid first character in AT&T syntax
(e.g. "{vex} vpmadd52huq ..."); MASM variant is to omit the braces.

Reviewed By: epastor

Differential Revision: https://reviews.llvm.org/D142321




More information about the All-commits mailing list