[all-commits] [llvm/llvm-project] 58e646: update_test_checks.py: pick up --tool from UTC_ARGS

[Nicolai Hähnle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 58e646c0e882a98fe71bc8ed469d43ad081b0f32
      https://github.com/llvm/llvm-project/commit/58e646c0e882a98fe71bc8ed469d43ad081b0f32
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  update_test_checks.py: pick up --tool from UTC_ARGS

It's not clear to me how to write a test for this. The tests run in an
environment where the tools may not be in PATH, and so the existing
custom-tool.test needs to use --tool-binary when invoking
update_test_checks.py. But it can't do so without also using --tool.

This change does fix a problem though with using
update_any_test_checks.py in an environment where the tools *are*
available in PATH.

Differential Revision: https://reviews.llvm.org/D142450


  Commit: 5b39387fb8aa6f8b755b633736f3548e348d0ee6
      https://github.com/llvm/llvm-project/commit/5b39387fb8aa6f8b755b633736f3548e348d0ee6
  Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  UpdateTestChecks: cleanup NamelessValues constructor

Remove global_ir_{prefix,prefix_regexp} (one of which is misnamed),
since they are really quite redundant with ir_{prefix,regexp} and
default the is_before_functions argument, which basically just adds
noise to the table of NamelessValues.

Differential Revision: https://reviews.llvm.org/D142451


Compare: https://github.com/llvm/llvm-project/compare/4ae221f5a4d1...5b39387fb8aa